Skip to content

[DX-285] React Native push notifications guide#3228

Open
maratal wants to merge 3 commits intomainfrom
DX-285-react-native-guide
Open

[DX-285] React Native push notifications guide#3228
maratal wants to merge 3 commits intomainfrom
DX-285-react-native-guide

Conversation

@maratal
Copy link
Collaborator

@maratal maratal commented Feb 26, 2026

Description

React Native push notifications tutorial.

https://ably.atlassian.net/browse/DX-285

Checklist

@coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 6b8f3099-bbe6-409d-be53-08711abbb5b2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch DX-285-react-native-guide

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@maratal maratal changed the base branch from main to DX-286-kotlin-push-guide February 26, 2026 23:31
@maratal maratal added the review-app Create a Heroku review app label Feb 26, 2026
@ably-ci ably-ci temporarily deployed to ably-docs-dx-285-react--62f9if February 26, 2026 23:32 Inactive
@ably-ci ably-ci temporarily deployed to ably-docs-dx-285-react--62f9if March 1, 2026 14:28 Inactive
@ably-ci ably-ci temporarily deployed to ably-docs-dx-285-react--62f9if March 1, 2026 17:54 Inactive
@maratal maratal force-pushed the DX-285-react-native-guide branch from 473e3a0 to 31c16f7 Compare March 1, 2026 19:51
@ably-ci ably-ci temporarily deployed to ably-docs-dx-285-react--62f9if March 1, 2026 19:51 Inactive
@ably-ci ably-ci temporarily deployed to ably-docs-dx-285-react--62f9if March 1, 2026 20:39 Inactive
@ably-ci ably-ci temporarily deployed to ably-docs-dx-285-react--62f9if March 1, 2026 21:11 Inactive
@ably-ci ably-ci temporarily deployed to ably-docs-dx-285-react--62f9if March 1, 2026 22:27 Inactive
@maratal maratal force-pushed the DX-285-react-native-guide branch from 55ea18f to 5b431eb Compare March 1, 2026 23:56
@ably-ci ably-ci temporarily deployed to ably-docs-dx-285-react--62f9if March 1, 2026 23:56 Inactive
@ably-ci ably-ci temporarily deployed to ably-docs-dx-285-react--62f9if March 2, 2026 01:13 Inactive
@ably-ci ably-ci had a problem deploying to ably-docs-dx-285-react--62f9if March 2, 2026 01:21 Failure
@ably-ci ably-ci temporarily deployed to ably-docs-dx-285-react--62f9if March 2, 2026 01:57 Inactive
@ably-ci ably-ci temporarily deployed to ably-docs-dx-285-react--62f9if March 2, 2026 10:03 Inactive
@maratal maratal force-pushed the DX-285-react-native-guide branch from 09bc9fb to f86cf42 Compare March 2, 2026 10:31
@ably-ci ably-ci temporarily deployed to ably-docs-dx-285-react--62f9if March 2, 2026 10:31 Inactive
@ably-ci ably-ci temporarily deployed to ably-docs-dx-285-react--62f9if March 2, 2026 11:46 Inactive
@maratal maratal force-pushed the DX-285-react-native-guide branch from 7db79f5 to 4de286b Compare March 2, 2026 15:10
@ably-ci ably-ci temporarily deployed to ably-docs-dx-285-react--62f9if March 2, 2026 15:10 Inactive
@maratal maratal force-pushed the DX-286-kotlin-push-guide branch from 789d8eb to 02ac81e Compare March 4, 2026 13:07
@maratal maratal force-pushed the DX-285-react-native-guide branch from 4de286b to 60d24d8 Compare March 4, 2026 13:08
@ably-ci ably-ci temporarily deployed to ably-docs-dx-285-react--62f9if March 4, 2026 13:08 Inactive
@GregHolmes GregHolmes force-pushed the DX-286-kotlin-push-guide branch from 02ac81e to 9942418 Compare March 5, 2026 11:25
Base automatically changed from DX-286-kotlin-push-guide to main March 5, 2026 11:38
@maratal maratal requested a review from GregHolmes March 5, 2026 13:18
@GregHolmes GregHolmes force-pushed the DX-285-react-native-guide branch from 60d24d8 to 061e171 Compare March 6, 2026 13:38
@GregHolmes GregHolmes temporarily deployed to ably-docs-dx-285-react--62f9if March 6, 2026 13:38 Inactive
@maratal maratal force-pushed the DX-285-react-native-guide branch from ccde4ca to 1bca1e8 Compare March 10, 2026 13:56
@ably-ci ably-ci temporarily deployed to ably-docs-dx-285-react--62f9if March 10, 2026 13:56 Inactive
@GregHolmes GregHolmes force-pushed the DX-285-react-native-guide branch from 1bca1e8 to d7548ce Compare March 13, 2026 10:40
@GregHolmes GregHolmes temporarily deployed to ably-docs-dx-285-react--62f9if March 13, 2026 10:41 Inactive
@GregHolmes GregHolmes force-pushed the DX-285-react-native-guide branch from d7548ce to 70bbbdd Compare March 13, 2026 11:11
@GregHolmes GregHolmes temporarily deployed to ably-docs-dx-285-react--62f9if March 13, 2026 11:12 Inactive
@GregHolmes
Copy link
Contributor

This is good, but I have one issue. The other guides focus on one language, so you don't switch between languages, but before you're using Kotlin, Ruby, Swift, React in here, we get a dropdown. Not only that, we always get code snippets that aren't available for the selected language.

Screenshot 2026-03-13 at 11 17 32 Screenshot 2026-03-13 at 11 17 29

@maratal
Copy link
Collaborator Author

maratal commented Mar 13, 2026

This is good, but I have one issue. The other guides focus on one language, so you don't switch between languages, but before you're using Kotlin, Ruby, Swift, React in here, we get a dropdown. Not only that, we always get code snippets that aren't available for the selected language.

Yes, good point, but isn't it a limitation of the current implementation? Either <Code> shouldn't be used in such cases, or user needs to jump between languages. What a third solution would be?

@maratal maratal added review-app Create a Heroku review app and removed review-app Create a Heroku review app labels Mar 20, 2026
@ably-ci ably-ci temporarily deployed to ably-docs-dx-285-react--gxefgp March 20, 2026 00:20 Inactive
@maratal maratal requested a review from m-hulbert March 23, 2026 18:44
@charlsteph8 charlsteph8 requested review from a team and splindsay-92 and removed request for a team March 24, 2026 10:38
@splindsay-92
Copy link
Contributor

This is good, but I have one issue. The other guides focus on one language, so you don't switch between languages, but before you're using Kotlin, Ruby, Swift, React in here, we get a dropdown. Not only that, we always get code snippets that aren't available for the selected language.

Yes, good point, but isn't it a limitation of the current implementation? Either <Code> shouldn't be used in such cases, or user needs to jump between languages. What a third solution would be?

I think it might be possible to wrap these in IF statements, but I'm not sure if that will work, worth a try though!

@splindsay-92
Copy link
Contributor

@maratal To avoid me having to go through all setup and configuration to test this, please can you provide a repo link that I can pull please? :) That will allow me to easily QA, preferably with test steps you used (i.e. what emulator etc..) you used for this?

Copy link
Contributor

@splindsay-92 splindsay-92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an initial comment again on if we should be using ably-js react hooks here. Also, would it make this whole guide a bit simpler/shorted if we made use of the dashboards ability to send notifications to device/clientId/Channel? We could still have basic code segments to show how its done, but there'd be no need for the additional UI/handling (also this page is due for a refurb).

I won't block the guide based on the current design though, but just a thought that might make things cleaner :)

@maratal maratal added review-app Create a Heroku review app and removed review-app Create a Heroku review app labels Mar 27, 2026
@ably-ci ably-ci temporarily deployed to ably-docs-dx-285-react--nyzhyw March 27, 2026 01:29 Inactive
@maratal maratal added review-app Create a Heroku review app and removed review-app Create a Heroku review app labels Mar 27, 2026
@ably-ci ably-ci temporarily deployed to ably-docs-dx-285-react--cnuuro March 27, 2026 01:38 Inactive
@maratal
Copy link
Collaborator Author

maratal commented Mar 27, 2026

Also, would it make this whole guide a bit simpler/shorted if we made use of the dashboards ability to send notifications to device/clientId/Channel? We could still have basic code segments to show how its done, but there'd be no need for the additional UI/handling (also this page is due for a refurb).

That's a fair point. But I think there is a real trade-off between completeness and brevity here — having the send functionality in the app gives readers something tangible to run themselves rather than deferring to an external interface for the most satisfying part of the exercise. Also, in general we tend to use Ably CLI for interacting with the service anyway. I would prefer to hear from other team members before cutting this. If the consensus is to go leaner, I am happy to make the change. wdyt @sacOO7 @m-hulbert @AndyTWF

Kotlin, XML, Ruby, and Swift blocks were inside <Code> components,
pulling them into the language switcher and causing mismatched tabs
for users with a different language selected. These are platform
config files that all readers need to see, so they are now plain
fenced code blocks.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The page is a React Native-only guide with no language switching.
Having react blocks inside <Code> caused the global language selector
to show Swift and other pubsub languages as options, resulting in
empty states for non-react selections.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ably-ci ably-ci had a problem deploying to ably-docs-dx-285-react--cnuuro March 27, 2026 02:26 Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-app Create a Heroku review app

Development

Successfully merging this pull request may close these issues.

4 participants