[DX-285] React Native push notifications guide#3228
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
473e3a0 to
31c16f7
Compare
55ea18f to
5b431eb
Compare
09bc9fb to
f86cf42
Compare
7db79f5 to
4de286b
Compare
789d8eb to
02ac81e
Compare
4de286b to
60d24d8
Compare
02ac81e to
9942418
Compare
60d24d8 to
061e171
Compare
ccde4ca to
1bca1e8
Compare
1bca1e8 to
d7548ce
Compare
d7548ce to
70bbbdd
Compare
Yes, good point, but isn't it a limitation of the current implementation? Either |
I think it might be possible to wrap these in IF statements, but I'm not sure if that will work, worth a try though! |
|
@maratal To avoid me having to go through all setup and configuration to test this, please can you provide a repo link that I can pull please? :) That will allow me to easily QA, preferably with test steps you used (i.e. what emulator etc..) you used for this? |
splindsay-92
left a comment
There was a problem hiding this comment.
Just an initial comment again on if we should be using ably-js react hooks here. Also, would it make this whole guide a bit simpler/shorted if we made use of the dashboards ability to send notifications to device/clientId/Channel? We could still have basic code segments to show how its done, but there'd be no need for the additional UI/handling (also this page is due for a refurb).
I won't block the guide based on the current design though, but just a thought that might make things cleaner :)
That's a fair point. But I think there is a real trade-off between completeness and brevity here — having the send functionality in the app gives readers something tangible to run themselves rather than deferring to an external interface for the most satisfying part of the exercise. Also, in general we tend to use Ably CLI for interacting with the service anyway. I would prefer to hear from other team members before cutting this. If the consensus is to go leaner, I am happy to make the change. wdyt @sacOO7 @m-hulbert @AndyTWF |
Kotlin, XML, Ruby, and Swift blocks were inside <Code> components, pulling them into the language switcher and causing mismatched tabs for users with a different language selected. These are platform config files that all readers need to see, so they are now plain fenced code blocks. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The page is a React Native-only guide with no language switching. Having react blocks inside <Code> caused the global language selector to show Swift and other pubsub languages as options, resulting in empty states for non-react selections. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>


Description
React Native push notifications tutorial.
https://ably.atlassian.net/browse/DX-285
Checklist